Repository navigation
Use externally-supplied workspace for mul! - #8
Merged
Merged
Conversation
Creates a `Workspace` type to hold the intermediate buffers used in `mul!` for multiplying a `FactoredMatrix` by another matrix without intermediate allocations. This has several advantages: - several different sizes of workspace can be created and reused as needed, e.g. for multiplying the same `FactoredMatrix` by different right-hand matrices with different numbers of columns. - it allows `FactoredMatrices` to be thread-safe - it avoids leaking an internal detail, the cache size, to users of the package. The workspace is created by calling `Workspace(fm, j)` where `fm` is a `FactoredMatrix` and `j` is the number of columns in the right-hand matrix for the intended multiplication. The workspace can then be passed to `mul!` via the `cache` keyword argument, e.g. `mul!(C, A, B; cache=ws)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a
Workspacetype to hold the intermediate buffers used inmul!for multiplying aFactoredMatrixby another matrix without intermediate allocations.This has several advantages:
FactoredMatrixby different right-hand matrices with different numbers of columns.FactoredMatricesto be thread-safeThe workspace is created by calling
Workspace(fm, j)wherefmis aFactoredMatrixandjis the number of columns in the right-hand matrix for the intended multiplication. The workspace can then be passed tomul!via thecachekeyword argument, e.g.mul!(C, A, B; cache=ws).